Skip to content

Add chart technical indicators#132

Open
Jiangzhewen wants to merge 1 commit into
capofficial:mainfrom
Jiangzhewen:technical-indicators
Open

Add chart technical indicators#132
Jiangzhewen wants to merge 1 commit into
capofficial:mainfrom
Jiangzhewen:technical-indicators

Conversation

@Jiangzhewen
Copy link
Copy Markdown

@Jiangzhewen Jiangzhewen commented May 12, 2026

Addresses #16

Summary

  • add MA20, MA50, EMA20, RSI(14), and MACD calculations for the existing lightweight chart
  • add compact indicator toggles to the current chart toolbar
  • persist indicator selections in userSettings.chartIndicators so refreshes keep the user's chart setup
  • keep OHLC hover values tied to the candlestick series when indicator series are visible

Scope note

This implements the simple technical indicators directly on the current lightweight-charts setup. I intentionally avoided adding an unverifiable TradingView proprietary-library placeholder or fake server drawing API endpoints; those would not run in this repository without licensed assets and backend support.

Validation

  • npm ci
  • git diff --check
  • npm run build
  • Playwright local check on /trade/ETH-USD with country and candle APIs mocked: verified MA20/MA50/EMA20/RSI/MACD controls render, MA20/RSI/MACD toggle active, and localStorage persistence survives reload

Payout address if accepted: USDC on Arbitrum One: 0xbb29837c5302E242CED1595d7BB8bA3ae7450362

@Jiangzhewen Jiangzhewen mentioned this pull request May 12, 2026
Open
@Jiangzhewen
Copy link
Copy Markdown
Author

Jiangzhewen commented May 12, 2026

Validation note:

  • npm ci: passed
  • git diff --check: passed
  • npm run build: passed
  • Playwright local check on /trade/ETH-USD with country and candle APIs mocked: verified indicator controls render, MA20/RSI/MACD toggle active, and persisted userSettings.chartIndicators survives reload

The Vercel check is the same account-level deployment block seen on other open PRs (why-is-my-account-deployment-blocked).

@Jiangzhewen
Copy link
Copy Markdown
Author

Jiangzhewen commented May 13, 2026

Vercel is failing before it reaches the project build with Account is blocked and links to Vercel's account-blocked help page, so this appears to be an account/deployment permission issue rather than a code failure. I re-ran npm run build locally on the current PR head and it completes successfully; the output only contains the existing Rollup/Svelte warnings already present in this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jiangzhewen